Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USB Link speeds #454

Merged
merged 5 commits into from
Feb 21, 2025
Merged

USB Link speeds #454

merged 5 commits into from
Feb 21, 2025

Conversation

peterdk
Copy link
Contributor

@peterdk peterdk commented Feb 20, 2025

So to round out the link speed stuff, here a PR for USB link versions/speeds.

I included the link speed, because people generally have no idea (myself included) what the difference between each USB version is. I did chose to remove the decimals where possible, cause those are not relevant.

All in all, it came out quite nicely. I really enjoyed looking at my USB devices and seeing the info.

@peterdk
Copy link
Contributor Author

peterdk commented Feb 20, 2025

Screenshot From 2025-02-20 19-32-30
Screenshot From 2025-02-20 19-32-37

@peterdk
Copy link
Contributor Author

peterdk commented Feb 20, 2025

I do see it's possible to have devices that are for example 3.2 but run at 3.1 speed, on ports where 3.1 is max.
We can read the version field of a device, that returns the USB version. But not sure if we want to show the info. Currently it displays max speed of device in this slot vs the max slot speed.

In theory you could show Current: USB 3.1 (10 Gb/s), Port max: USB 3.1 (10 Gb/s), Device max: USB 3.2 (20 Gb/s)
Not sure if we want to go this verbose. For now I would say the current vs slot max we have in this PR is useful enough. But let me know what you think!

@nokyan
Copy link
Owner

nokyan commented Feb 20, 2025

That was quick, thanks a lot!

Not sure if we want to go this verbose. For now I would say the current vs slot max we have in this PR is useful enough. But let me know what you think!

I think in this case I'd prefer just showing the current actual speed. That way it's not confusing and we don't need to be too verbose.

@peterdk
Copy link
Contributor Author

peterdk commented Feb 20, 2025

I think in this case I'd prefer just showing the current actual speed. That way it's not confusing and we don't need to be too verbose.

I assume you are referring to current/max right? Or do you want to only show current and never the optionalmax?
Cause I do really like to see that my devices aren't using the full speed of the ports, just like the PCIe and SATA variants.

@nokyan
Copy link
Owner

nokyan commented Feb 20, 2025

I assume you are referring to current/max right? Or do you want to only show current and never the optionalmax? Cause I do really like to see that my devices aren't using the full speed of the ports, just like the PCIe and SATA variants.

I meant only current. But I see your use case for having more than that displayed. I think displaying current/max port speed like PCIe and SATA is a good compromise then and I feel like that's what most people would expect if they saw it. :)

@nokyan
Copy link
Owner

nokyan commented Feb 21, 2025

Are we ready to merge then? :)

@peterdk
Copy link
Contributor Author

peterdk commented Feb 21, 2025

Are we ready to merge then? :)

Ah yes. I am not waiting for anything :).

@nokyan nokyan merged commit 56e2e74 into nokyan:main Feb 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants